Math.cbrt -> Math.pow #6220
Math.cbrt -> Math.pow #6220
Conversation
|
@likangning93, thanks for the pull request! Maintainers, we have a signed CLA from @likangning93, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Nice fix. |
| @@ -466,7 +466,7 @@ define([ | |||
| // Typical use case is leaves, where lower estimates of interpoint distance might | |||
| // lead to underattenuation. | |||
| var sphereVolume = content._tile.contentBoundingVolume.boundingSphere.volume(); | |||
| content._baseResolutionApproximation = Math.cbrt(sphereVolume / pointsLength); | |||
| content._baseResolutionApproximation = Math.pow(sphereVolume / pointsLength, 1/3); // IE doesn't support cbrt | |||
There was a problem hiding this comment.
@lilleyse To prevent this problem in the future, should we add CesiumMath.cbrt that does the right thing depending on if Math.cbrt is available? This way if the "native" cbrt is faster or more accurate we get the benefit as well.
Also, keeping with convention, these should be 1.0/3.0.
IE doesn't support
Math.cbrt, which was causing point cloud 3D Tiles to fail.