Fix JavaScript parsing error in IE 10 and earlier #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Cesium doesn't work in IE10, we need to allow the JS to parse so that an app can still function without Cesium. In this case, Uint8ClampedArray isn't supported in IE 10, so the arraySlice polyfill was throwing on load. I cleaned up `arraySlide` and deduplicated rom TypedArray code into FeatureDetection. To Test, load Viewer in IE11 with the debugger open and set to IE10 compatibility mode.
|
@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
hpinkos
reviewed
Apr 2, 2018
Source/Core/arraySlice.js
Outdated
| return copy; | ||
| }; | ||
| var copy = Array.prototype.slice.call(array, begin, end); | ||
| var typedArrayTypes = FeatureDetection.typedarrayTypes; |
There was a problem hiding this comment.
typearrayTypes -> typedArrayTypes?
|
That's it, this change looks fine |
|
Thanks, should be ready. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Cesium doesn't work in IE10, we need to allow the JS to parse so that an app can still function without Cesium. In this case, Uint8ClampedArray isn't supported in IE 10, so the arraySlice polyfill was throwing on load. I cleaned up
arraySliceand deduplicated common TypedArray code into FeatureDetection.To Test, load Viewer in IE11 with the debugger open and set to IE10 compatibility mode.