Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statistics for tiles that fail processing #6558

Merged
merged 4 commits into from
May 9, 2018
Merged

Fix statistics for tiles that fail processing #6558

merged 4 commits into from
May 9, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented May 3, 2018

The tileset statistics were incorrect for tiles that failed processing (e.g. loading a b3dm+draco tile in IE). This also meant tilesLoaded would return false forever.

Also tried to organize the tile success and tile failure logic better.

stats

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse lilleyse mentioned this pull request May 3, 2018
3 tasks
@pjcozzi pjcozzi requested a review from likangning93 May 6, 2018 01:03
lilleyse added a commit that referenced this pull request May 8, 2018
Copy link
Contributor

@likangning93 likangning93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, and I'm finding the new failure/success handlers are easier to follow than the old code.

@hpinkos
Copy link
Contributor

hpinkos commented May 9, 2018

Thanks @lilleyse! And thanks for reviewing @likangning93!

@hpinkos hpinkos merged commit 4f888c2 into master May 9, 2018
@hpinkos hpinkos deleted the stats-bug branch May 9, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants