Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move small Sandcastle tilesets to SampleData #6861

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Move small Sandcastle tilesets to SampleData #6861

merged 3 commits into from
Jul 31, 2018

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jul 30, 2018 •
edited
Loading

Move smaller sample tilesets to SampleData directory instead of hosting in ion.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@ggetz ggetz requested a review from lilleyse July 30, 2018 20:54
@lilleyse
Copy link
Contributor

The instanced tileset in the Many Clipping Planes demo is getting an error:

Uncaught TypeError: instancedUrl.then is not a function (on line 182)

Otherwise looks good.

@ggetz ggetz mentioned this pull request Jul 31, 2018
Closed
7 tasks
@ggetz
Copy link
Contributor Author

ggetz commented Jul 31, 2018

Thanks @lilleyse ! Updated.

@lilleyse
Copy link
Contributor

👍

@lilleyse lilleyse merged commit 4bbf35e into master Jul 31, 2018
@lilleyse lilleyse deleted the tilesets-sample-data branch July 31, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilleyse lilleyse Awaiting requested review from lilleyse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggetz @cesium-concierge @lilleyse