Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ion tilesets to 3D Tiles 1.0 #6862

Merged
merged 10 commits into from
Jul 31, 2018
Merged

Update ion tilesets to 3D Tiles 1.0 #6862

merged 10 commits into from
Jul 31, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jul 31, 2018

For #6697
Fixes #5504
Fixes #6832

Not complete yet, but opening now to show that it's in progress.

To do:

  • St. Helens
  • Chappes
  • AGI HQ
  • Update NYC tileset
    • Figure out glTF Validator error (skipped for now)
  • San Miguel - @likangning93 has a glTF 2.0 version, but we need to fix shininess problems
  • Power Plant - we can't upgrade this one yet. It requires KHR_techniques_webgl and this PR: Update gltf Pipeline and support KHR_techniques_webgl and KHR_blend #6805. But we'll be able to update right after that is merged.
  • AGI HQ is now positioned on Cesium terrain
    • 3D Tiles Photogrammetry Classification - need to update classification tileset to align with AGI HQ. Edit transform. The classification tileset can probably live in SampleData instead of ion now.
    • Classification - need to move classification geometries to align with AGI HQ
  • Point Cloud Classification - the geometry tileset needs content.url to content.uri update. Small enough to live in SampleData now.
  • 3D Tiles Terrain Classification - the vector tileset needs content.url to content.uri update

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor Author

lilleyse commented Jul 31, 2018

@ggetz could you take a look at the AGI HQ, Point Cloud Classification, and 3D Tiles Terrain Classification ones?

The upgrade command in 3d-tiles-tools (2.0-tools branch) should be working properly now, though manually editing the tileset.json for some of these may be quicker.

@ggetz
Copy link
Contributor

ggetz commented Jul 31, 2018

@lilleyse Updated all the Classification examples.

@lilleyse
Copy link
Contributor Author

Made some small edits to the new tilesets in ad21f1f.

Someone besides @ggetz and me should test and merge. @tfili, since you are doing the release?

@tfili tfili merged commit d3ad8bd into master Jul 31, 2018
@tfili tfili deleted the sandcastle-tilesets branch July 31, 2018 20:49
@tfili
Copy link
Contributor

tfili commented Jul 31, 2018

Thanks @lilleyse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Every 3D Tiles Sandcastle example warns of deprecation 3D Tiles - Update sample tilesets
4 participants