Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeFlyToLocationForRectangle needs to wait for terrain to become … #6909

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 10, 2018

…ready

If you performed a geocode before the terrain became ready, it would throw an exception.

Fixes #6908.

Review this with whitespace diffing off, this PR is 99% indentation changes.

CC @lilleyse

…ready

If you performed a geocode before the terrain became ready, it would
throw an exception.

Fixes #6908.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor

Thanks, the fix works great.

@lilleyse lilleyse merged commit 58b7c7a into master Aug 10, 2018
@lilleyse lilleyse deleted the wait-for-ready branch August 10, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants