Fix tests in #6805 #7050
Merged
Fix tests in #6805 #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
ggetz
reviewed
Sep 19, 2018
There was a problem hiding this comment.
Besides that style comment, everything looks good. Thanks @OmarShehata!
Specs/Scene/ModelSpec.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('renders with the KHR_materials_pbrSpecularGlossiness extension when no textures are found', function() { | ||
| return loadModel(boomBoxPbrSpecularGlossinessNoTextureUrl).then(function(model) { | ||
| model.show = false; | ||
| model.zoomTo(2); |
There was a problem hiding this comment.
Here and throughout, 2 should be 2.0
|
Should be good now, thanks for the quick review @ggetz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing tests from #6805 (comment).
@ggetz let me know how this looks. The new expectation is just that the rendered model looks different than before rendering. If it can load those 3 models without crashing it should at least guarantee that the spec gloss code still works when textures are provided vs just a base color etc.