Tileset mixed refinement fix #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Updated. @ggetz could you review? |
ggetz
reviewed
Oct 1, 2018
| @@ -316,6 +316,13 @@ define([ | |||
| return; | |||
| } | |||
|
|
|||
| if (tile.hasTilesetContent && tile.children.length > 0) { | |||
There was a problem hiding this comment.
I'd add a quick comment to explain why this is needed.
There was a problem hiding this comment.
Also we're already defining var hasChildren = tile.children.length > 0; on line 334, move it up here?
|
@ggetz Updated. |
|
Looks good, thanks @lilleyse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7084
The problem was a tile referencing an external tileset would pass the visibility test but it's child, the root of the external tileset, would not due to the
cullWithChildrenBoundsoptimization. This is why #7084 could only be replicated in views where the root's children were all off screen. The external tileset would not refine further and would select its nearest loaded ancestor, causing the tileset to render mixed LODs.The fix is to use the root tile's visibility in place of its parent's visibility so that the traversal never gets to the parent tile in the first place.
To do: