Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply gamma correction to silhouette color #7563

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Conversation

lilleyse
Copy link
Contributor

Fixes #7558

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@emackey
Copy link
Contributor

emackey commented Feb 13, 2019

This change seems good, although the resulting color is still not exactly what the user requested. Looks like the color may be going through tone-mapping or similar, preventing the brightest colors from being reached.

Although small, this probably warrants a mention in CHANGES.md, since all silhouette colors will be changed by this.

@lilleyse
Copy link
Contributor Author

@emackey Updated.

When scene.highDynamicRange = false the rendered color should be the exact requested color.

@emackey emackey merged commit 9219277 into master Feb 15, 2019
@emackey emackey deleted the gamma-correct-silhouette branch February 15, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants