-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for particle system scaling/sizing in world space #7746
Support for particle system scaling/sizing in world space #7746
Conversation
…orld space as opposed to screen space.
Thanks for the pull request @richard3d!
Reviewers, don't forget to make sure that:
|
Thanks for the PR @richard3d! We'll try to look at this in the next week or so |
Yikes! I just pushed a change to fix the merge conflict with |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
2 similar comments
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@richard3d the AppVeyor failure may have been a fluke. I would try resolving the merge conflict, merge in master and it'll re-run the CI. |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@lilleyse can you review this? |
@richard3d does Merijn Wijngaard also work at Prominent Edge and is he covered by your CLA? Could you add Merijn and yourself to the Corporate CLA section? |
I pushed a few small tweaks in e190735. I'm noticing some strange behavior in one of the Sandcastle examples that uses particle bursts. |
Never mind, I think Merijn was accidentally added twice to |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
3 similar comments
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @richard3d! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@richard3d can you address the comments from the review? #7746 (comment) |
Whatever this was, I don't see it anymore. My theory is it was one of those bugs where hidden points/billboard would either take up the whole screen or stay in the center of the screen that we fixed. |
I updated |
Thanks @lilleyse! And thanks @richard3d and @criyson! |
Allows particle system billboards to be sized in world space via
sizeInMeters
property that was added and cascaded to billboards during update/creation process.