Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for particle system scaling/sizing in world space #7746

Merged
merged 7 commits into from
Feb 26, 2020

Conversation

richard3d
Copy link
Contributor

Allows particle system billboards to be sized in world space via sizeInMeters property that was added and cascaded to billboards during update/creation process.

@cesium-concierge
Copy link

Thanks for the pull request @richard3d!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Apr 15, 2019

Thanks for the PR @richard3d! We'll try to look at this in the next week or so

@richard3d
Copy link
Contributor Author

richard3d commented Apr 25, 2019

Yikes! I just pushed a change to fix the merge conflict with CONTRIBUTORS.md can someone advise why my latest push caused AppVeyor to fail @hpinkos ? I would really like to get this PR in :)

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

2 similar comments
@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@OmarShehata
Copy link
Contributor

@richard3d the AppVeyor failure may have been a fluke. I would try resolving the merge conflict, merge in master and it'll re-run the CI.

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

@lilleyse can you review this?

@lilleyse
Copy link
Contributor

@richard3d does Merijn Wijngaard also work at Prominent Edge and is he covered by your CLA? Could you add Merijn and yourself to the Corporate CLA section?

@lilleyse
Copy link
Contributor

I pushed a few small tweaks in e190735.

I'm noticing some strange behavior in one of the Sandcastle examples that uses particle bursts. sizeInMeters seems to be exposing some other bug where the particle bursts fill the whole screen. Local sandcastle

particle

@lilleyse
Copy link
Contributor

@richard3d does Merijn Wijngaard also work at Prominent Edge and is he covered by your CLA? Could you add Merijn and yourself to the Corporate CLA section?

Never mind, I think Merijn was accidentally added twice to CONTRIBUTORS.md. I've made the correction.

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

3 similar comments
@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@cesium-concierge
Copy link

Thanks again for your contribution @richard3d!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 29, 2020

@richard3d can you address the comments from the review? #7746 (comment)

@hpinkos
Copy link
Contributor

hpinkos commented Feb 26, 2020

@lilleyse @criyson opened the same change as this in #8603. Do you think we can get this one merged, or is the weirdness you saw when testing a showstopper?

@lilleyse
Copy link
Contributor

lilleyse commented Feb 26, 2020

Do you think we can get this one merged, or is the weirdness you saw when testing a showstopper?

Whatever this was, I don't see it anymore. My theory is it was one of those bugs where hidden points/billboard would either take up the whole screen or stay in the center of the screen that we fixed.

@lilleyse
Copy link
Contributor

I updated CHANGES.md 53400d8. Good to merge whenever CI passes.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 26, 2020

Thanks @lilleyse!

And thanks @richard3d and @criyson!

@hpinkos hpinkos merged commit bb009aa into CesiumGS:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants