Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use rubbish OBB for single root tile #7769

Merged
merged 5 commits into from
Apr 29, 2019
Merged

Do not use rubbish OBB for single root tile #7769

merged 5 commits into from
Apr 29, 2019

Conversation

kring
Copy link
Member

@kring kring commented Apr 24, 2019

Fixes #7702

@cesium-concierge
Copy link

Thanks for the pull request @kring!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Apr 29, 2019

@tfili or @bagnell can one of you take a look at this?

@tfili tfili merged commit 2df5944 into master Apr 29, 2019
@tfili tfili deleted the mercator-culling branch April 29, 2019 20:11
@tfili
Copy link
Contributor

tfili commented Apr 29, 2019

Thanks @kring

@OmarShehata OmarShehata mentioned this pull request Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black scene when heading south with custom heightmap terrain-provider
5 participants
@kring @cesium-concierge @mramato @tfili @hpinkos