Terrain back face culling option #8470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
OmarShehata
reviewed
Dec 18, 2019
|
Cool! Make sure to close #7266 once this is merged. |
|
Thanks @OmarShehata. @IanLilleyT can you review and merge? |
|
Looks good to me, thanks @lilleyse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7266
Adds
globe.backFaceCullingto support viewing terrain from below the surface. There will be a follow up PR for disabling skirts, a few other PRs after that for camera controls, and then ultimately an "Underground" Sandcastle example.Local sandcastle