Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8479 - Fix grey screen on Other/Unclassified toggle #8538

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Conversation

Samulus
Copy link
Contributor

@Samulus Samulus commented Jan 14, 2020

Fixes #8479 , tested on Linux / Firefox / Proprietary NVIDIA driver. Also tested on Windows with the proprietary Nvidia driver

@Samulus Samulus requested a review from lilleyse January 14, 2020 19:49
@cesium-concierge
Copy link

Thanks for the pull request @Samulus!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Confirmed this works on Linux/Chrome/Nvidia and Mac 2015/Chrome/AMD.

@lilleyse
Copy link
Contributor

@Samulus just add an entry to CHANGES.md and I'll merge

@Samulus
Copy link
Contributor Author

Samulus commented Jan 14, 2020

@lilleyse Added CHANGES.md

@lilleyse
Copy link
Contributor

Thanks @Samulus!

Hopefully this same fix can apply to #7557 and any other systems that hide points in this way.

@lilleyse lilleyse merged commit 0a45aef into master Jan 14, 2020
@lilleyse lilleyse deleted the 8479/grey_screen branch January 14, 2020 21:00
@Samulus
Copy link
Contributor Author

Samulus commented Jan 14, 2020

Thanks @Samulus!

Hopefully this same fix can apply to #7557 and any other systems that hide points in this way.

Doesn't apply from what I can see, I'm able to reproduce that bug with this commit on Nvidia / Linux still

@lilleyse
Copy link
Contributor

@Samulus ah too bad..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point covers entire screen when hidden
3 participants