Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8321/polyline crash #8546

Merged
merged 14 commits into from
Jan 23, 2020
Merged

8321/polyline crash #8546

merged 14 commits into from
Jan 23, 2020

Commits on Jan 21, 2020

  1. Simplify removePolylines

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    8e22caf View commit details
    Browse the repository at this point in the history

  2. Add .filter approach to syncing polyLinesToUpdate

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c9fccaa View commit details
    Browse the repository at this point in the history

  3. Add for loop approach to sync polyLinesToUpdate

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c67751d View commit details
    Browse the repository at this point in the history

  4. Replace const and let with var for es5

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    412f931 View commit details
    Browse the repository at this point in the history

  5. Convert es6 for loops to es5

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    6440049 View commit details
    Browse the repository at this point in the history

  6. Remove redundant polyLinesToUpdate synchronization code

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    73d4f95 View commit details
    Browse the repository at this point in the history

  7. Style / length cacheing fixes

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    76519b4 View commit details
    Browse the repository at this point in the history

  8. Replace defined checks for polyline with isDestroyed getter, combine … 

    …for loops [skip ci]
    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    0e2c460 View commit details
    Browse the repository at this point in the history

  9. Add splice logic back into remove function to fix failing Jasmine tests

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    b06dd0a View commit details
    Browse the repository at this point in the history

  10. Fix minor grammar issue 

    [skip ci]
    @Samulus
    Samulus authored and Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    ef55935 View commit details
    Browse the repository at this point in the history

  11. Add missing '!'

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    9be14c3 View commit details
    Browse the repository at this point in the history

  12. Remove splicing logic in remove, update unittests

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    f81aea0 View commit details
    Browse the repository at this point in the history

  13. Add suggested style changes [skip ci]

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    b0aacf3 View commit details
    Browse the repository at this point in the history

  14. Update CHANGES.md [skip ci]

    Samuel Vargas committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    080a3fa View commit details
    Browse the repository at this point in the history