Fix 1.67 ground polygon regression #8694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance improvements #8630 did not take into account the limitation that ground primitives that overlap cannot be batched together. This change uses the `RectangleCollisionChecker` already implemented for `StaticGroundGeometryMaterialBatch` and performs the same check in `StaticGroundGeometryColorBatch`.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
|
Looks good, thanks @mramato |
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance improvements #8630 did not take into account the limitation that ground primitives that overlap cannot be batched together.
This change uses the
RectangleCollisionCheckeralready implemented forStaticGroundGeometryMaterialBatchand performs the same check inStaticGroundGeometryColorBatch.A big thanks to @likangning93 who figured out the root cause of the problem and pointed me to the existing collision checker.
Fixes #8664