Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog post process sandcastle #8798

Merged
merged 1 commit into from
May 29, 2020
Merged

Fog post process sandcastle #8798

merged 1 commit into from
May 29, 2020

Conversation

lilleyse
Copy link
Contributor

While working on globe translucency I created a fog post process effect that might be nice to include in sandcastle. It's implemented with a custom post process where the fog distance and color are uniforms and can be changed dynamically.

fog

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@cesium-concierge
Copy link

Thanks again for your contribution @lilleyse!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@hpinkos
Copy link
Contributor

hpinkos commented May 29, 2020

Thanks @lilleyse! This is a great demo =)

@hpinkos hpinkos merged commit fffeeea into master May 29, 2020
@hpinkos hpinkos deleted the fog-post-process branch May 29, 2020 14:26
@hpinkos
Copy link
Contributor

hpinkos commented May 29, 2020

Added a comment to CHANGES.md here 7efc915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants