Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tileset.extensions getter #8829

Merged
merged 4 commits into from
May 7, 2020
Merged

Add tileset.extensions getter #8829

merged 4 commits into from
May 7, 2020

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented May 7, 2020

Adds a getter for the extensions object in the tileset JSON

@Samulus can you review? This is relevant to grabbing the extent shape from 3DTILES_extent.

@lilleyse lilleyse requested a review from Samulus May 7, 2020 16:43
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Samulus
Samulus approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@Samulus Samulus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilleyse 👍 lgtm

@Samulus Samulus merged commit 8b5539f into master May 7, 2020
@lilleyse lilleyse deleted the tileset-extensions branch May 7, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samulus Samulus Samulus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilleyse @cesium-concierge @Samulus