Added frustumSplits option to DebugCameraPrimitive #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @IanLilleyT!
Reviewers, don't forget to make sure that:
|
|
Confirmed that this works for a user-created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8848
This lets the creator of a
DebugCameraPrimitiveoptionally supply the frustum splits to use when rendering the debug camera. This is useful for debugging multi-frustum cameras. If not specified, the frustum splits are the near and far values of the camera, which is the desired behavior for the averageCameraobject.The old way always used
FrameState'sfrustum splits, which didn't make sense for arbitrary cameras.Example with near value of 1 and far value of 10000000 (almost diameter of earth)
Before:
After: