Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json to exports so it can be resolved #9105

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

wallw-teal
Copy link
Contributor

Many tools attempt to require.resolve package.json, and in the latest versions of node that is not possible if the package specifies exports. The solution is to simply add package.json to exports.

Resolves #8992

Many tools attempt to require.resolve package.json, and in the latest
versions of node that is not possible if the package specifies exports.
The solution is to simply add package.json to exports.

Resolves CesiumGS#8992
@cesium-concierge
Copy link

Thanks for the pull request @wallw-bits!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@kring
Copy link
Member

kring commented Aug 21, 2020

Thanks @wallw-bits!

@kring kring merged commit fa2edd6 into CesiumGS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants