Add support for EXT_texture_webp #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
reviewed
Jan 22, 2019
specs/data/2.0/extensions/EXT_image_webp/box-textured-embedded/box-textured-embedded.gltf
Outdated
Show resolved
Hide resolved
specs/data/2.0/extensions/EXT_image_webp/box-textured-separate/box-textured-with-fallback.gltf
Outdated
Show resolved
Hide resolved
specs/data/2.0/extensions/EXT_image_webp/box-textured-separate/box-textured-with-fallback.gltf
Outdated
Show resolved
Hide resolved
specs/data/2.0/extensions/EXT_image_webp/box-textured-separate/box-textured-separate.gltf
Outdated
Show resolved
Hide resolved
|
@lilleyse should be cleaner and a bit more robust now. The sampler was indeed not part of the extension so I've removed it. |
OmarShehata
changed the title
|
Now that the extension has been merged, I think this is ready to merge @lilleyse . |
|
Looks good. Just update |
|
Thanks @lilleyse . Let me know how this looks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the draft EXT_image_webp extension. It was originally in #448 but the approach changed since the extension was updated, so it was easier to branch from master.
It looks like with the new structure, there isn't anything beyond the WebP header check needed in gltf-pipeline. I added the same tests and sample models to verify that it can take a model with the WebP extension, with and without a fallback image, and it won't toss it. I tested the output models in CesiumJS with the WebP PR and both gltf/glb work correctly.
@lilleyse this is ready but should not be merged until the extension is merged.