Do not enable seeder signal handlers in tests #16079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Fixed
|
jack60612
approved these changes
Aug 19, 2023
emlowe
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
There are two reasons for this. One relates to
RuntimeError: set_wakeup_fd only works in main thread of the main interpreterwhich is triggered because tooling under pytest-xdist uses threads (sometimes) as I believe is discussed in pytest-dev/execnet#96. The other is that it messes up pytest's own handling of signals which meansctrl+cand such don't work well.It would be great at some point to bring consistency to our signal handling. I started that awhile back in #13568 and will add a note there about taking care of the seeder as well.
Current Behavior:
New Behavior:
Testing Notes:
Daft For: