Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Excluding Logic for Preprocessor #2813

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Sep 24, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This PR should fix issue #2795 reported by @CodingWonders

Testing

Compiled WinUtil successfully in both PowerShell 5 & 7, and the main issue of .git getting corrupted by the preprocessor shouldn't happen again.

Impact

This won't impact End-Users, but the Developers who work on WinUtil (to be specific, devs who work in PowerShell 5 environment, which we're currently supporting with PowerShell 7).

Issue related to PR

Additional Information

This was reported first by @CodingWonders on WinUtil Community Discord, so thanks again for notifying me (and others) about this issue 😄.

Also, I do realize that the preprocessor is very slow at the moment ( considering it doesn't do that complex of a task :/ ), will try to optimize / make it feature complete in the future, but for the time being.. my bad for wasting your time in compile times 🙃.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@CodingWonders
Copy link
Contributor

@og-mrk, I've tested your change and it works fine on PowerShell 5

Copy link
Contributor

@ruxunderscore ruxunderscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, on my end. Don't see the same error I had before my -Force "fix", so this rewrite was definitely needed. Since, this also fixes @CodingWonders problems with compiling in Powershell 5, then I say this is amazing. This kind of rewrite was something I planned on doing. Thanks!

@ChrisTitusTech ChrisTitusTech merged commit 806cbd0 into ChrisTitusTech:main Oct 1, 2024
1 check passed
@og-mrk og-mrk deleted the fix-excluding-logic-in-preprocessor branch October 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation script messes up the .git folder in PowerShell 5
5 participants