CU-2hz5ump deid mulitprocessing #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-2hz5ump Multi-processing De-ID pipe not working |
…tests" This reverts commit 5e22334.
…essing DeID tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I looked into DeID model multiprocessing and it looked like it wasn't working at all.
However, I did end up get multiprocessing to work within tests.
The takeaway right now:
TransformersNERclass ends up in a state that makes multiprocessing failSo while the multiprocessing works during testing, this is very much a workaround.
PS:
I do not know the actual issue.
I did do a bunch of debugging and all I could find out is that after the
trainmethod onTransformersNERis called, it is no longer able to be used as part of the pipe for whatever reason. I did narrow down the issue to below the line 195 in the method. The error I got was this one:https://gist.github.com/mart-r/0927125010c54fb4d89adabc0cfb00c9
So if anyone knows what the actual fix would be, please do let me know.