Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8693ruk7p: Bump mypy version in dev-requirements #396

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Feb 8, 2024

Mypy currenlty checks torch and fails along with GitHub Actions because of it.

Seems that bumping the mypy version fixes the issue.

This PR:

  • Bumps mypy version to >=1.7.0
  • Allows compatible extensions (mypy-extensions>=1.0.0)
  • Pins mypy max version to current major version (<2.0.0)

@tomolopolis
Copy link
Member

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 0a9a615 into master Feb 8, 2024
5 checks passed
mart-r added a commit that referenced this pull request Feb 9, 2024
* CU-8693ruk7p: Bump mypy version (along with extensions) in dev-requirements

* CU-8693ruk7p: Pin max major version for mypy
mart-r added a commit that referenced this pull request Feb 12, 2024
* Bump django from 3.2.23 to 3.2.24 in /webapp/webapp

Bumps [django](https://github.com/django/django) from 3.2.23 to 3.2.24.
- [Commits](django/django@3.2.23...3.2.24)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* CU-8693ruk7p: Bump mypy version in dev-requirements (#396) (#398)

* CU-8693ruk7p: Bump mypy version (along with extensions) in dev-requirements

* CU-8693ruk7p: Pin max major version for mypy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mart Ratas <mart.ratas@gmail.com>
@mart-r mart-r deleted the CU-8693ruk7p-mypy-checking-packages branch March 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants