Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deid logging update #466

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Deid logging update #466

merged 3 commits into from
Jul 29, 2024

Conversation

shubham-s-agarwal
Copy link
Collaborator

This minor update is to document chunking (better) and add logging for it as well

Pushing change to document chunking and add logging for it as well
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use lazy evaluation in logging unless there's an explicit reason not to.

medcat/tokenizers/transformers_ner.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe the only left over comment:

Is this all the logging DeID needs? Perhaps there's need for more logging somewhere? If so, would be great to address it all at once. If this is all we need, then great!

@shubham-s-agarwal
Copy link
Collaborator Author

I feel we've covered all of it.
Tom please let me know in case you feel we could add it anywhere else.

@shubham-s-agarwal shubham-s-agarwal self-assigned this Jul 24, 2024
@tomolopolis
Copy link
Member

fine without further debug statements. Adding debug elsewhere you see fit is up to you, but the Trainer callback also has the same purpose

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shubham-s-agarwal shubham-s-agarwal merged commit d20bf25 into master Jul 29, 2024
8 checks passed
@shubham-s-agarwal shubham-s-agarwal deleted the deid_logging_update branch July 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants