Create Nix Flake #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a Nix flake with a derivation generated using `cargo2nix`. This also begins checking `Cargo.lock` into version control (which is required for reproducibility.)
|
Tested with Fault, seems to be working A-OK but the coverage is lower than I expected (probably a difference in how we calculate coverage). But that's beside the point for this particular PR. |
|
Is the coverage lower than Atalanta on some tests, or is it just <100% coverage? I'd expect coverage to be optimal, but ISCAS benchmarks just have a lot of gates that are not observable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mean, you knew this was comingAdds a Nix flake with a derivation generated using
cargo2nix. This also begins checkingCargo.lockinto version control (which is required for reproducibility.)I'm still testing this so I'll keep this as a draft for now.