Add profitable transaction selector #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
profitable-tx-selector
branch
from
aef6c92
to
96cc501
Compare
.../main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorCliOptions.java
Outdated
Show resolved
Hide resolved
...c/test/java/net/consensys/linea/sequencer/txselection/ProfitableTransactionSelectorTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julien Marchand <julien-marchand@users.noreply.github.com>
|
@julien-marchand updated default min margin to 1.0 |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…quencer-plugins into profitable-tx-selector
Filter94
reviewed
Jan 9, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Outdated
Show resolved
Hide resolved
fab-10
commented
Jan 9, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Outdated
Show resolved
Hide resolved
Filter94
reviewed
Jan 9, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Outdated
Show resolved
Hide resolved
Filter94
reviewed
Jan 9, 2024
...c/test/java/net/consensys/linea/sequencer/txselection/ProfitableTransactionSelectorTest.java
Show resolved
Hide resolved
…selection/selectors/ProfitableTransactionSelector.java Co-authored-by: Roman Vaseev <4833306+Filter94@users.noreply.github.com>
…r a gas price bump Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jonesho
reviewed
Jan 9, 2024
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Filter94
approved these changes
Jan 10, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
|
As discussed today in the call with @julien-marchand , the formula needs to be updated include the transaction compression we do already: -45 bytes per tx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Consensys/protocol-misc/issues/860, depends on Consensys/linea-besu#30