Fix incorrect heap size value for boxed slice #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `GetSize` impl for a boxed slice didn't have a bound on `T`, so `get_size` was being called on `&T` instead of `T`. This meant that the size of each element was always being calculated to the size of a reference. This change fixes that and adds a test.
nicmue
added a commit
to everestsystems/get-size
that referenced
this pull request
Oct 26, 2023
Adds the enhancements proposed by: - DKerp/get-size#11 - DKerp/get-size#13 Also adds support for `uuid`, `dashmap` and `serde_json`.
|
@DKerp ping |
This was referenced Sep 9, 2024
Open
|
@CeleritasCelery Ping |
|
Hey @bircni Thanks for taking ownership of this code! I am going to switch to using |
|
No Problem @CeleritasCelery please feel free to raise other issues or pull requests ! |
|
the next version I publish will include your changes! |
|
Also opened an issue here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
GetSizeimpl for a boxed slice didn't have a bound onT, soget_sizewas being called on&Tinstead ofT. This meant that the size of each element was always being calculated to the size of a reference. This change fixes that and adds a test.