Implimented GetSize for Arc<str>, tokio sync and fixed size of the &str #17
+74
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnvOut
force-pushed
the
Implimented-GetSize-for-Arc<str>,-tokio-sync-and-fixed-size-of-the-&str
branch
from
71daa7f
to
dbe6a0b
Compare
EnvOut
force-pushed
the
Implimented-GetSize-for-Arc<str>,-tokio-sync-and-fixed-size-of-the-&str
branch
from
dbe6a0b
to
e7d7519
Compare
droundy
reviewed
Apr 17, 2024
Comment on lines
-143
to
+146
| impl GetSize for Duration {} | ||
| impl GetSize for SystemTime {} | ||
|
|
||
| impl GetSize for Duration { | ||
| fn get_stack_size() -> usize { | ||
| 12 | ||
| } | ||
| } |
There was a problem hiding this comment.
question: Why make this change for Duration?
It seems like the default implementation based on size_of should be correct.
| fn test_arc_str_size(){ | ||
| let str_text = "a"; | ||
| let arc: Arc<str> = Arc::from(str_text); | ||
| assert_eq!(arc.get_size(), std::mem::size_of::<usize>() + std::mem::size_of_val(str_text)); |
There was a problem hiding this comment.
suggestion: This is incorrect.
The total size should include the stack size of the Arc itself. In total it needs to store the 1 byte for the "a" plus the count (a usize) plus the fat pointer, which would be another two usizes worth of space.
Comment on lines
+339
to
+341
| fn get_size(&self) -> usize { | ||
| std::mem::size_of::<usize>() + (&**self).get_size() | ||
| } |
There was a problem hiding this comment.
suggestion: Shouldn't this be get_heap_size?
I think your
Suggested change
| fn get_size(&self) -> usize { | |
| std::mem::size_of::<usize>() + (&**self).get_size() | |
| } | |
| fn get_heap_size(&self) -> usize { | |
| std::mem::size_of::<usize>() + (&**self).get_size() | |
| } |
Comment on lines
+345
to
+347
| fn get_size(&self) -> usize { | ||
| std::mem::size_of::<usize>() + (&**self).get_size() | ||
| } |
There was a problem hiding this comment.
suggestion: As above, this should be get_heap_size
Suggested change
| fn get_size(&self) -> usize { | |
| std::mem::size_of::<usize>() + (&**self).get_size() | |
| } | |
| fn get_heap_size(&self) -> usize { | |
| std::mem::size_of::<usize>() + (&**self).get_size() | |
| } |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.