Feature: Remove need of use get_size::GetSize for #[derive(get_size::GetSize)]
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e::GetSize)]`
This commit enhances the user experience by eliminating the need for
explicit import statements when using `#[derive(get_size::GetSize)]`.
Previously, the use of this derive required an accompanying
`use get_size::GetSize;` statement, without which the compiler would
raise a not-found trait error.
- **Automatic Trait Reference:**
- The derived code now references the `GetSize` trait using the full
path `::get_size::GetSize`. This change ensures that the trait is
recognized by the compiler without requiring an explicit import
statement by the user.
- **Use Case for Protobuf:**
- This update is particularly beneficial in scenarios like adding
derives to protobuf-generated code, where manually importing traits
can be challenging or impossible.
This commit simplifies the development process by streamlining the use
of the `GetSize` derive and improving compatibility with generated code
bases.
This was referenced Sep 9, 2024
Open
|
@drmingdrmer Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the user experience by eliminating the need for explicit import statements when using
#[derive(get_size::GetSize)]. Previously, the use of this derive required an accompanyinguse get_size::GetSize;statement, without which the compiler would raise a not-found trait error.Automatic Trait Reference:
GetSizetrait using the full path::get_size::GetSize. This change ensures that the trait is recognized by the compiler without requiring an explicit import statement by the user.Use Case for Protobuf:
This commit simplifies the development process by streamlining the use of the
GetSizederive and improving compatibility with generated code bases.