Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.x - Header, navbar, and admin sidebar refactoring #2858

Merged
merged 17 commits into from
Apr 10, 2024

Conversation

davide-negretti
Copy link
Contributor

@davide-negretti davide-negretti commented Mar 7, 2024

References

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@davide-negretti davide-negretti marked this pull request as ready for review March 8, 2024 10:22
@alanorth alanorth changed the title Header, navbar, and admin sidebar refactoring 7.x - Header, navbar, and admin sidebar refactoring Mar 19, 2024
@tdonohue tdonohue added this to the 7.6.2 milestone Apr 10, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @davide-negretti ! I've verified this works for 7.x and it appears to apply all the same fixes as #2676 I've retested all the various accessibility fixes on 7.x and they all appear to have been fixed there as well.

I'm merging this into dspace-7_x. However, this PR likely requires mention in the 7.6.2 Release Notes because it refactors the header/navbar/side menu. Those refactors may cause some errors to occur in custom themes when sites upgrade from 7.6.1 to 7.6.2

@tdonohue tdonohue merged commit de1a240 into DSpace:dspace-7_x Apr 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants