Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving accessibility of the login button #3261

Closed

Conversation

Andrea-Guevara
Copy link

References

Description

Use of the “attr.aria-disabled” attribute to improve the accessibility of the log in button.

Instructions for Reviewers

In the component “log-in-password.component”, in the login button, the attribute “[disabled]” has been replaced by “[attr.aria-disabled]”. Styling has also been added to maintain the disabled effect while the button is not enabled.

List of changes in this PR:

  • Addition of the “[attr.aria-disabled]” attribute.
  • Styling of the “btn-primary:disabled” class

To reproduce:

  1. Go to the login area.
  2. Navigate the keyboard using a screen reader.
  3. See that the “login” button, even if disabled, is accessible by keyboard navigation and screen readers.

@tdonohue tdonohue added bug accessibility authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release duplicate and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 27, 2024
@tdonohue
Copy link
Member

This appears to have been replaced / superseded by #3268. Because @artlowel had asked to claim #3249 first, and they implemented a larger fix, I'm closing this PR as "won't fix".

Please see #3268 instead.

@tdonohue tdonohue closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility authorization related to authorization, permissions or groups bug duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The log in button is not fully accessible to users using a screen reader
2 participants