Upgrade to Cypress 13.14.2 #3315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing if tab is active. Fix small bug in login-modal test.
tdonohue
added
dependencies
tdonohue
commented
Sep 10, 2024
| "@angular/core": "^17.3.11" | ||
| "@angular/animations": "^17.3.11", | ||
| "@angular/common": "^17.3.11", | ||
| "@angular/core": "^17.3.11" |
There was a problem hiding this comment.
NOTE: These indentation changes were made by npm itself. I didn't modify this file manually, but ran an npm install to upgrade Cypress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Upgrades us to Cypress 13.14.2, which also resolves a security alert related to Cypress v12 (NOTE: This alert doesn't impact production as Cypress is only used to run e2e tests.)
In addition to the Cypress upgrade, the following minor changes were made to ensure better e2e test stability:
item-edit.cy.tsto check that the proper tab is active. This solves some random e2e failures which were occurring when an accessibility scan was triggered before the tabs were fully loaded on the page. This check forces Cypress to wait for the tabs to appear before proceeding.login-modal.cy.tsto fix a minor bug & to simplify the CSS selectors.command.tsto simplify CSS selectors. (The CSS selector cleanup here & above is just minor cleanup that can be done now that Header, navbar, and admin sidebar refactoring #2676 is merged, because we no longer have duplicate elements in the DOM)Instructions for Reviewers