Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] ebpfless: disable procfs scanning by default #24592

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

YoannGh
Copy link
Contributor

@YoannGh YoannGh commented Apr 11, 2024

What does this PR do?

After further testing it turned out that procfs scanning had unexpected side effects.
This PR disables it by default to avoid these.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 31884697 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31884697 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Regression Detector

Regression Detector Results

Run ID: ca1a6f7b-d64b-4494-8c11-1231dbc4c4a1
Baseline: 40536c3
Comparison: cd34497

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +0.17 [-5.14, +5.48]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +3.43 [+0.83, +6.03]
file_tree memory utilization +1.43 [+1.31, +1.55]
uds_dogstatsd_to_api_cpu % cpu utilization +0.45 [-2.54, +3.44]
tcp_syslog_to_blackhole ingress throughput +0.19 [+0.10, +0.28]
file_to_blackhole % cpu utilization +0.17 [-5.14, +5.48]
process_agent_real_time_mode memory utilization +0.12 [+0.08, +0.17]
trace_agent_json ingress throughput +0.05 [+0.01, +0.09]
otel_to_otel_logs ingress throughput +0.01 [-0.43, +0.45]
trace_agent_msgpack ingress throughput +0.00 [-0.02, +0.02]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.06, +0.02]
process_agent_standard_check_with_stats memory utilization -0.05 [-0.10, +0.01]
process_agent_standard_check memory utilization -0.09 [-0.16, -0.03]
idle memory utilization -0.16 [-0.20, -0.12]
pycheck_1000_100byte_tags % cpu utilization -2.98 [-7.82, +1.87]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@YoannGh
Copy link
Contributor Author

YoannGh commented Apr 11, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 11, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit db17595 into main Apr 11, 2024
219 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yoanngh/disable-procfs-scan branch April 11, 2024 11:02
agent-platform-auto-pr bot pushed a commit that referenced this pull request Apr 11, 2024
dd-mergequeue bot pushed a commit that referenced this pull request Apr 11, 2024
Co-authored-by: YoannGh <yoann.ghigoff@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants