Skip ddtrace profiling extension #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
approved these changes
Nov 16, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Skip ddtrace profiling extension e19e3ab
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
Nov 17, 2022
**What does this PR do?**: In #2358 we changed how the profiling native extension is built in CI by adding the `-Werror` compiler option to turn warnings into errors. We did this automatically by checking if the `CI` environment variable was set to `true`. Unfortunately, this broke at least one user, see <DataDog/datadog-api-client-ruby#1137>. The warning that was triggered in that case was actually not relevant, see my investigation in <#2377>. The `CI=true` was never meant to trigger outside of our CI, but clearly it's too generic of a name for us to rely on that. To fix this, I've gone ahead and changed the configuration so that `-Werror` only gets added when `DD_PROFILING_CI=true`. I also changed our docker and CircleCI configurations to set this by default. **Motivation**: This issue affected one Datadog internal customer -- <DataDog/datadog-api-client-ruby#1137>. This should never happen -- we don't want any issues when compiling the profiling bits to affect ddtrace installation. **Additional Notes**: (Nothing) **How to test the change?**: Validate that `-Werror` only gets added when `DD_PROFILING_CI=true`. To trigger a warning for testing, try removing `DDTRACE_UNUSED` from function argument declarations, and you should see that the compiler starts failing due to that. --- Fixes #2377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing due to the install of ddtrace failing. The install failure happens when building the extension, so this PR is for temporarily skipping the extension while apm-ruby investigates the root cause of the install failure.