Skip to content

Commit

Permalink
Rename DD_PROFILING_CI to more general DDTRACE_CI
Browse files Browse the repository at this point in the history
  • Loading branch information
ivoanjo committed Nov 18, 2022
1 parent 96a8649 commit 2eefe99
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test_containers:
GRPC_RUBY_BUILD_PROCS: 6
DD_INSTRUMENTATION_TELEMETRY_ENABLED: false
TEST_REDIS_OLD_HOST: redis_old
DD_PROFILING_CI: true
DDTRACE_CI: true
- &container_parameters_environment
- *container_base_environment
- TEST_DATADOG_INTEGRATION: 1
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ services:
- TEST_REDIS_HOST=redis
- TEST_REDIS_OLD_HOST=redis_old
- TEST_REDIS_OLD_PORT=6379
- DD_PROFILING_CI=true
- DDTRACE_CI=true
stdin_open: true
tty: true
volumes:
Expand Down
2 changes: 1 addition & 1 deletion ext/ddtrace_profiling_loader/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def add_compiler_flag(flag)

# Because we can't control what compiler versions our customers use, shipping with -Werror by default is a no-go.
# But we can enable it in CI, so that we quickly spot any new warnings that just got introduced.
add_compiler_flag '-Werror' if ENV['DD_PROFILING_CI'] == 'true'
add_compiler_flag '-Werror' if ENV['DDTRACE_CI'] == 'true'

# Older gcc releases may not default to C99 and we need to ask for this. This is also used:
# * by upstream Ruby -- search for gnu99 in the codebase
Expand Down
2 changes: 1 addition & 1 deletion ext/ddtrace_profiling_native_extension/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def add_compiler_flag(flag)

# Because we can't control what compiler versions our customers use, shipping with -Werror by default is a no-go.
# But we can enable it in CI, so that we quickly spot any new warnings that just got introduced.
add_compiler_flag '-Werror' if ENV['DD_PROFILING_CI'] == 'true'
add_compiler_flag '-Werror' if ENV['DDTRACE_CI'] == 'true'

# Older gcc releases may not default to C99 and we need to ask for this. This is also used:
# * by upstream Ruby -- search for gnu99 in the codebase
Expand Down

0 comments on commit 2eefe99

Please sign in to comment.