Add query string test for net/http integration

spec/datadog/tracing/contrib/ethon/easy_patch_spec.rb

@@ -248,4 +248,15 @@
       expect(span.get_tag('out.host')).to eq('example.com')
     end
   end
+
+  context 'when query string in url' do
+    it 'does not collect string' do
+      easy = EthonSupport.ethon_easy_new(url: 'http://example.com/sample/path?foo=bar')
+
+      easy.perform
+
+      expect(span.get_tag('http.url')).to eq('/sample/path')
+      expect(span.get_tag('out.host')).to eq('example.com')
+    end
+  end
 end

spec/datadog/tracing/contrib/excon/instrumentation_spec.rb

@@ -412,4 +412,20 @@
       expect(span.get_tag('out.host')).to eq('example.com')
     end
   end
+
+  context 'when query string in url' do
+    before do
+      call_web_mock_function_with_agent_host_exclusions { |options| WebMock.enable! options }
+      stub_request(:get, /example.com/).to_return(status: 200)
+    end
+
+    after { WebMock.disable! }
+
+    it 'does not query string' do
+      Excon.get('http://example.com/sample/path?foo=bar')
+
+      expect(span.get_tag('http.url')).to eq('/sample/path')
+      expect(span.get_tag('out.host')).to eq('example.com')
+    end
+  end
 end

spec/datadog/tracing/contrib/faraday/middleware_spec.rb

@@ -152,6 +152,20 @@
           expect { response }.to_not output(/WARNING/).to_stderr
         end
       end
+
+      context 'with query sting in url' do
+        subject(:response) { client.get('http://example.com/success?foo=bar') }
+
+        it 'does not collect query string' do
+          expect(response.status).to eq(200)
+
+          expect(span.get_tag('http.url')).to eq('/success')
+        end
+
+        it 'executes without warnings' do
+          expect { response }.to_not output(/WARNING/).to_stderr
+        end
+      end
     end
   end
 

spec/datadog/tracing/contrib/http/request_spec.rb

@@ -554,4 +554,33 @@ def expect_request_without_distributed_headers
       expect(span.get_tag('out.host')).to eq('example.com')
     end
   end
+
+  context 'when query string in url' do
+    before do
+      call_web_mock_function_with_agent_host_exclusions { |options| WebMock.enable! options }
+      stub_request(:get, /example.com/).to_return(status: 200)
+    end
+
+    after { WebMock.disable! }
+
+    it 'does not collect query string' do
+      uri = URI('http://example.com/sample/path?foo=bar')
+
+      Net::HTTP.get_response(uri)
+
+      expect(span.get_tag('http.url')).to eq('/sample/path')
+      expect(span.get_tag('out.host')).to eq('example.com')
+    end
+
+    it 'does not collect query string' do
+      uri = URI('http://example.com/sample/path')
+      params = { :foo => "bar" }
+      uri.query = URI.encode_www_form(params)
+
+      Net::HTTP.get_response(uri)
+
+      expect(span.get_tag('http.url')).to eq('/sample/path')
+      expect(span.get_tag('out.host')).to eq('example.com')
+    end
+  end
 end

spec/datadog/tracing/contrib/httpclient/instrumentation_spec.rb

@@ -334,5 +334,16 @@
         expect(span.get_tag('out.host')).to eq('localhost')
       end
     end
+
+    context 'when query string in url' do
+      let(:path) { '/sample/path?foo=bar' }
+
+      it 'does not collect query string' do
+        response
+
+        expect(span.get_tag('http.url')).to eq('/sample/path')
+        expect(span.get_tag('out.host')).to eq('localhost')
+      end
+    end
   end
 end

spec/datadog/tracing/contrib/httprb/instrumentation_spec.rb

@@ -337,5 +337,16 @@
         expect(span.get_tag('out.host')).to eq('localhost')
       end
     end
+
+    context 'when query string in url' do
+      let(:path) { '/sample/path?foo=bar' }
+
+      it 'does not collect auth info' do
+        response
+
+        expect(span.get_tag('http.url')).to eq('/sample/path')
+        expect(span.get_tag('out.host')).to eq('localhost')
+      end
+    end
   end
 end

spec/datadog/tracing/contrib/rest_client/request_patch_spec.rb

@@ -208,6 +208,21 @@
       end
     end
 
+    context 'when query string in url' do
+      let(:path) { '/sample/path?foo=bar' }
+
+      before do
+        stub_request(:get, /example.com/).to_return(status: status, body: response)
+      end
+
+      it 'does not collect query string' do
+        request
+
+        expect(span.get_tag('http.url')).to eq('/sample/path')
+        expect(span.get_tag('out.host')).to eq('example.com')
+      end
+    end
+
     context 'that returns a custom response object' do
       subject(:request) do
         RestClient::Request.execute(method: :get, url: url) { response }