Fix outdated references to use instead of instrument in docs
#2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reviewing #2217 where we fixed the sinatra documentation not to mention the outdated `use`, I decided to make a quick check if we had any more such leftovers, and it turns out we did. This PR fixes the two leftover mentions of `use` that I found that should be replaced by `instrument`. I did not change the sinatra docs to avoid a conflict with #2217.
TonyCTHsu
approved these changes
Aug 22, 2022
|
The failing tests seem to be related to the newly-released msgpack 1.5.5. I'll merge this PR and let's investigate that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR fixes the two leftover mentions of
usein the docs that I found that should be replaced byinstrument. I did not change the sinatra docs to avoid a conflict with #2217.Motivation:
While reviewing #2217 where we fixed the sinatra documentation not to mention the outdated
use, I decided to make a quick check if we had any more such leftovers, and it turns out we did.How to test the change?:
Check that the documentation is actually correct now / build an example app and check that
instrumentcorrectly instruments it.