-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL comment propagation for pg
#2339
Merged
TonyCTHsu
merged 10 commits into
master
from
feature/dbm-sql-comment-propagation-for-pg
Oct 31, 2022
Merged
SQL comment propagation for pg
#2339
TonyCTHsu
merged 10 commits into
master
from
feature/dbm-sql-comment-propagation-for-pg
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
feature/dbm-sql-comment-propagation-for-pg
branch
from
October 27, 2022 19:29
0ab46c2
to
d36f022
Compare
TonyCTHsu
force-pushed
the
feature/dbm-sql-comment-propagation-for-pg
branch
from
October 27, 2022 19:53
d36f022
to
4c7b093
Compare
Codecov Report
@@ Coverage Diff @@
## feature/dbm-sql-comment-propagation #2339 +/- ##
=======================================================================
- Coverage 98.30% 98.30% -0.01%
=======================================================================
Files 1100 1100
Lines 58242 58283 +41
=======================================================================
+ Hits 57256 57295 +39
- Misses 986 988 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Oct 28, 2022
Base automatically changed from
feature/dbm-sql-comment-propagation
to
master
October 31, 2022 11:30
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Inject sql comment to enable database monitoring.
By default, it is
disabled
.With
service
mode, our tracer propagates service context to database, which enable Datadog to build service map.