[PROF-5943] Ruby VM forking fixes for new profiler #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already were testing if the worker thread was alive in native code (which is why a different instance of the profiler could already be started), but did not properly allow the same `CpuAndWallTimeWorker` to be restarted.
There's two situations that can happen here (see comments in code), and in either situation we want to ensure that at most one `gc_tracepoint` is active (or none, if disabled).
Base automatically changed from
ivoanjo/prof-6288-ci-warnings-into-errors
to
master
November 10, 2022 14:18
ivoanjo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR collects fixes for two issues related to the new profiler and Ruby apps that employ fork. See individual commits for details.
Motivation:
We fully support Ruby applications that use fork, so I've been spending time making sure the new profiler is correct for these applications as well.
Additional Notes:
I suspect there may be a few more fixes needed before the new profiler is solid on Ruby apps that use fork, so expect more PRs on this subject.
This PR is on top of #2358 as I wanted to avoid any conflicts, but is independent of it
How to test the change?:
Both changes include test coverage. Additionally, the first change can be easily observed by checking that the profiler restarts successfully after a fork in a Ruby app that uses forking.