Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve redis integration patching #2470

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Dec 6, 2022

What does this PR do?

Until redis 4, all instrumentation happened in one gem: redis. Since redis 5, instrumentation happens in a separate gem: redis-client. Because redis 4 does not depend on redis-client, it's possible for both gems to be installed at the same time.

For example, if sidekiq 7 and redis 4 are installed: both redis and redis-client will be installed.

This implementation improves the patching condition to apply to whenever it is possible.

PS. The minimun redis-client supported would be 0.11.0, where Config#custom is implemented.

@TonyCTHsu TonyCTHsu self-assigned this Dec 6, 2022
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Dec 6, 2022
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/redis-integration-versioning branch from 6758b47 to 6bcbbca Compare December 6, 2022 21:43
@TonyCTHsu TonyCTHsu marked this pull request as ready for review December 6, 2022 21:44
@TonyCTHsu TonyCTHsu requested a review from a team December 6, 2022 21:44
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
@TonyCTHsu TonyCTHsu merged commit d5f94d0 into master Dec 7, 2022
@TonyCTHsu TonyCTHsu deleted the tonycthsu/redis-integration-versioning branch December 7, 2022 11:13
@github-actions github-actions bot added this to the 1.8.0 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants