Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C: Propagate unknown values as-is #2485

Merged
merged 3 commits into from
Dec 22, 2022
Merged

W3C: Propagate unknown values as-is #2485

merged 3 commits into from
Dec 22, 2022

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 8, 2022

Unknown Datadog-specific fields should be propagated as-is, as they might belong to future versions Datadog Tracers.

ddtrace's job is to simply pass the them downstream with the same incoming values.

@marcotc marcotc requested a review from a team December 8, 2022 22:53
@marcotc marcotc self-assigned this Dec 8, 2022
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable, although this is one of those PRs that it's probably best someone from tracing give a second pass as I understand the code changes, but I don't understand if they are the correct code changes for the outcome we want ;)

spec/datadog/tracing/distributed/trace_context_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

end
end

[origin, sampling_priority, tags]
[origin, sampling_priority, tags, unknown_fields]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should extract this to its own object, if the array keeps on growing. It feels weird to me that the caller need to understand the index of the array to get the corresponding value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it if we get to 5! 🦆

@marcotc marcotc merged commit fb52399 into master Dec 22, 2022
@marcotc marcotc deleted the w3c-propagate-unknown branch December 22, 2022 01:04
@github-actions github-actions bot added this to the 1.9.0 milestone Dec 22, 2022
@TonyCTHsu TonyCTHsu mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants