Allow debase-ruby_core_source 3.2.0 to be used
#2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: Allow using the latest `debase-ruby_core_source` together with dd-trace-rb. **Motivation**: As discussed in #1740, we decided to pin the range of versions of `debase-ruby_core_source` we use, so that we can validate each version as it comes out. The changes on 3.2.0 (<https://my.diffend.io/gems/debase-ruby_core_source/0.10.18/3.2.0>) don't impact dd-trace-rb, because they only affect Ruby 3.2.0 and 2.0.0 and we don't use `debase-ruby_core_source` on Ruby >= 2.6 (nor support Ruby 2.0). Nevertheless, it's important we keep our version up-to-date as customers may need the latest version of `debase-ruby_core_source` for other gems they use. **Additional Notes**: (None) **How to test the change?**: CI should still be green for all supported Ruby versions.
marcotc
approved these changes
Jan 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Allow using the latest
debase-ruby_core_sourcetogether with dd-trace-rb.Motivation:
As discussed in #1740, we decided to pin the range of versions of
debase-ruby_core_sourcewe use, so that we can validate each version as it comes out.The changes on 3.2.0
(https://my.diffend.io/gems/debase-ruby_core_source/0.10.18/3.2.0) don't impact dd-trace-rb, because they only affect Ruby 3.2.0 and 2.0.0 and we don't use
debase-ruby_core_sourceon Ruby >= 2.6 (nor support Ruby 2.0).Nevertheless, it's important we keep our version up-to-date as customers may need the latest version of
debase-ruby_core_sourcefor other gems they use.Additional Notes:
CI is breaking for Ruby 3.2 for an unrelated reason.Update: fixed.How to test the change?:
CI should still be green for all supported Ruby versions.