Commits on Jan 20, 2023

1. Allow profiler development on arm64 macOS …

   **What does this PR do?**:
   
   This PR tweaks the ruby platform check prior to compiling the profiling
   native extension to allow compilation on arm64 macOS.
   
   We already allowed for arm64 on Linux, but the architecture is reported
   differently on macOS than on Linux (aarch64 vs arm64). (Because of
   course it would be reported differently!)
   
   **Motivation**:
   
   We don't officially support the Continuous Profiler on macOS BUT it
   actually mostly works, and so we have a toggle to enable it for
   development and testing purposes.
   
   But up until now all macOS development had been on x86-64, and thus
   I had not noticed that our checks were too restrictive to allow
   development on arm64 macOS.
   
   **Additional Notes**:
   
   If there's enough customer interest, we may explore officially
   supporting profiling on macOS at some point.
   
   **How to test the change?**:
   
   Change includes test coverage. You can also test it if you have an arm64
   macOS machine, by checking that
   
   ```bash
   DD_PROFILING_MACOS_TESTING=true bundle exec rake clean compile
   ```
   
   does not complain about the architecture not being supported.
   
   (It will probably complain about a missing libdatadog, which is
   another thing you'll need to compile manually on macOS).

   

   ivoanjo committed Jan 20, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 59c46ad
   • Browse repository at this point

   Copy the full SHA

   59c46ad View commit details

   Browse the repository at this point in the history