[PROF-7171] Enable Ruby 3.2 testing in CI #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to work now, most gems have been updated for 3.2.
Otherwise the presto specs always fail.
Let's get this show on the road!
ivoanjo
force-pushed
the
ivoanjo/enable-ruby-3.2-ci
branch
from
faf60e9
to
b8a028e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 1143 1145 +2
Lines 62024 62075 +51
Branches 2790 2801 +11
==========================================
+ Hits 60811 60860 +49
- Misses 1213 1215 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR finally enables dd-trace-rb testing in CI with Ruby 3.2 (both CircleCI as well as GitHub actions).
It requires the fixes from #2600, which is why it currently also includes those commits. I plan to rebase this to remove them once that other PR is removed, but I wanted to see a green CI build for 3.2.All done!Motivation:
Enable our customers to use Ruby 3.2, and be confident that there are no regressions.
Additional Notes:
This PR depends on #2600, and that's why I'm opening it as a draft.#2600 has now been merged, marking as ready to review.How to test the change?:
Validate that the "test-3.2" target shows up and is green on CircleCI; validate that 3.2 shows up and is green on GitHub Actions.