Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presto/Elasticsearch/qless updates #2608

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?
Updates various integrations based on unified naming convetion:

presto - adds spankind: client and db.system: presto
elasticsearch - adds spankind: client
qLess - adds spankind: consumer

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 8, 2023
@zarirhamza zarirhamza marked this pull request as ready for review February 8, 2023 21:28
@zarirhamza zarirhamza requested a review from a team February 8, 2023 21:28
@zarirhamza zarirhamza added do-not-merge/WIP Not ready for merge and removed do-not-merge/WIP Not ready for merge labels Feb 8, 2023
@marcotc
Copy link
Member

marcotc commented Feb 13, 2023

@zhamza99 is this still do-not-merge/WIP? Looks fine code-wise.

@zarirhamza
Copy link
Contributor Author

@zhamza99 is this still do-not-merge/WIP? Looks fine code-wise.

Need to discuss this and get approval from other teams, but will notify you when it's good to go

@ivoanjo
Copy link
Member

ivoanjo commented Feb 14, 2023

(Should we mark this as draft until that happens?)

@zarirhamza zarirhamza marked this pull request as draft February 14, 2023 15:31
@zarirhamza zarirhamza removed the do-not-merge/WIP Not ready for merge label Feb 14, 2023
@zarirhamza zarirhamza marked this pull request as ready for review February 17, 2023 19:42
@zarirhamza
Copy link
Contributor Author

@marcotc and @ivoanjo we should be good to go now

@marcotc marcotc merged commit cebb067 into master Feb 17, 2023
@marcotc marcotc deleted the zarir/presto-elasticsearch-qless-spankind branch February 17, 2023 22:53
@github-actions github-actions bot added this to the 1.10.0 milestone Feb 17, 2023
@marcotc marcotc changed the title Presto/Elasticsearch/qLess updates Presto/Elasticsearch/qless updates Feb 17, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants