[PROF-7192] Minor: Extend stack collector to be able to record the alloc-samples metric #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loc-samples metric **What does this PR do?**: This PR enables an additional "value type" attached to profiling samples -- the `alloc-samples` metric. This will be used to expose more profiling information in follow-up PRs. **Motivation**: I've extracted this from a bigger branch, but this is in good shape for merging already. **Additional Notes**: (N/A) **How to test the change?**: Change includes test coverage.
marcotc
approved these changes
Feb 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR enables an additional "value type" attached to profiling samples -- the
alloc-samplesmetric. This will be used to expose more profiling information in follow-up PRs.Motivation:
I've extracted this from a bigger branch, but this is in good shape for merging already.
Additional Notes:
(N/A)
How to test the change?:
Change includes test coverage.