Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TeamCity env var extraction #2668

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Update TeamCity env var extraction #2668

merged 2 commits into from
Mar 6, 2023

Conversation

albertvaka
Copy link
Contributor

What does this PR do?

Adds a test for TeamCity and updates the env var extraction to match the spec.

Also fixes a small and harmless copy-paste error that caused to try to read Azure Pipelines env vars in other providers.

Motivation
Improve support for TeamCity.

How to test the change?
Updated the fixtures generated from the ciapp spec.

@albertvaka albertvaka added the ci-app CI product for test suite instrumentation label Mar 6, 2023
@albertvaka albertvaka requested a review from a team March 6, 2023 11:39
@marcotc marcotc merged commit 380a29a into master Mar 6, 2023
@marcotc marcotc deleted the albertvaka/fix-teamcity branch March 6, 2023 19:53
@github-actions github-actions bot added this to the 1.11.0 milestone Mar 6, 2023
@lloeki lloeki modified the milestones: 1.11.0, 1.10.1 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-app CI product for test suite instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants