-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config transport endpoint #2678
Conversation
Pending:
|
lib/datadog/core/transport/config.rb
Outdated
# TODO: not sure if we're supposed to do that as we don't chunk like traces | ||
# Datadog.health_metrics.transport_chunked(responses.size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to skip this then, no worries.
We can probably extract some methods for parsing |
Some implementation decisions (e.g fallback value handling) depend on the consumer of the response, therefore they are left undecided.
d87729b
to
82cb46b
Compare
Codecov Report
@@ Coverage Diff @@
## add-info-transport-endpoint #2678 +/- ##
===============================================================
- Coverage 98.04% 98.01% -0.03%
===============================================================
Files 1178 1180 +2
Lines 64556 64799 +243
Branches 2884 2904 +20
===============================================================
+ Hits 63294 63513 +219
- Misses 1262 1286 +24
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What does this PR do?
Add
/v0-7/config
endpoint and corresponding transport.Motivation
Remote configuration.
Additional Notes
A dedicated transport is required, see #2676
How to test the change?
The code is isolated and uncalled, so CI should stay green.
Manual testing: