Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test:Fix start_with typo #2719

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Test:Fix start_with typo #2719

merged 1 commit into from
Mar 24, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Mar 24, 2023

Minor typo on String#start_with? method. Does not affect test correctness, but breaks deadline thread.

@marcotc marcotc requested a review from a team March 24, 2023 17:56
@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Mar 24, 2023
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Mar 24, 2023
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgghhh thanks Marco for fixing my derps

@marcotc marcotc merged commit 25686d4 into master Mar 24, 2023
@marcotc marcotc deleted the minor-spec branch March 24, 2023 20:10
@github-actions github-actions bot added this to the 1.11.0 milestone Mar 24, 2023
@lloeki lloeki modified the milestones: 1.11.0, 1.11.0.beta1 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants